Skip to content

style: use --code-font for code sections#3461

Merged
jakebailey merged 1 commit intomicrosoft:v2from
DrNayak2306:v2
Dec 1, 2025
Merged

style: use --code-font for code sections#3461
jakebailey merged 1 commit intomicrosoft:v2from
DrNayak2306:v2

Conversation

@DrNayak2306
Copy link
Contributor

@DrNayak2306 DrNayak2306 commented Nov 22, 2025

Replace hard-coded JetBrains Mono font stack with the custom chosen font
saved in --code-font in markdown-twoslash.scss to ensure consistent code
font theming across the site.

@DrNayak2306
style: use --code-font for code sections
a5b1723 
Replace hard-coded JetBrains Mono font stack with the custom chosen font
 in markdown-twoslash.scss to ensure consistent code font
theming across the site.
@DrNayak2306
Copy link
Contributor Author

DrNayak2306 commented Nov 22, 2025

Initially this is what changing the code font option in customization did - nothing

Font 1
cur-1
Font 2
cur-2

And this is what the merged change does
Font 1
new-1
Font 2
new-2

@jakebailey jakebailey added the deploy-preview Enables automatic deployments to preview environments on a PR label Nov 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-plant-05c166c10-3461.centralus.5.azurestaticapps.net

@DrNayak2306
Copy link
Contributor Author

DrNayak2306 commented Nov 26, 2025

Just checking in — this PR has a deploy preview ready.
Could someone let me know if anything is blocking review or if further changes are required?

@DrNayak2306
Copy link
Contributor Author

DrNayak2306 commented Nov 28, 2025

Hi @jakebailey, whenever you have time could you help with a review or guide next steps? Thanks!

jakebailey
jakebailey approved these changes Dec 1, 2025
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was blocking was me being on vacation 🙂

@jakebailey jakebailey merged commit 5daeca1 into microsoft:v2 Dec 1, 2025
9 checks passed
@DrNayak2306
Copy link
Contributor Author

DrNayak2306 commented Dec 2, 2025

Thanks for taking the time to review this, and hope you had a great vacation.
I also wanted to add a copy-to-clipboard utility to all the code-blocks the way MDN docs or Chrome Developer docs does, but after reading issue #2804 wasn't sure of proceeding since it is essentially an infrastructural change.
Let me know if I can help with ANYTHING.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakebailey jakebailey jakebailey approved these changes

Assignees

No one assigned

Labels

deploy-preview Enables automatic deployments to preview environments on a PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DrNayak2306 @jakebailey